search

VedalAI / neuro-amongus

Among Us Plugin for Neuro-sama
GNU General Public License v3.0
540 stars 49 forks source link

Separate plugin functionality and do some code cleanup #13

Closed Alexejhero closed 1 year ago

Alexejhero commented 1 year ago

Changes made in this pull request

I have also added a bunch of TODOs which should be eventually addressed in the project.

Closes #4

Alexejhero commented 1 year ago

This code should be almost equivalent to what is currently on master. I have added a bunch of TODOs that need to be taken care of, either before or after this pull request is merged.

I would appreciate code reviews so I know if I have to change other than what I have already marked.

It might be wise to merge this soon to avoid more conflicts with future contributions but at the same time it's still not as finished as I would like it to.

ScrubN commented 1 year ago

Currently this crashes on my machine when I try to load into a practice map (not sure why) so I think some fixes are required. I like the direction of the organisation though it's a lot cleaner than before and the mono behaviours are super cool.

Found your crash PepeLa image

ScrubN commented 1 year ago

Edit: Solved by fixing NodeFromWorldPoint(), which Vedal caught the error earlier.

For some reason, certain grid sizes larger than \~250 cause it to behave extremely weirdly, including not appearing at 300 and generating only out-of-bounds at 400 and 500.

I have only tested on this issues on this PR branch, not master, and I have only tested the sizes: 200, 202, 250, 300, 400, 500.

Alexejhero commented 1 year ago

For certain maps it might be a good idea to include an offset for the pathfinding grid so we don't have to increase its size too much to fit everything.

Alexejhero commented 1 year ago

This pull request is ready to be merged, unless more reviews are added.