VedalAI / neuro-amongus

Among Us Plugin for Neuro-sama
GNU General Public License v3.0
540 stars 49 forks source link

More project refactoring #29

Closed Alexejhero closed 1 year ago

Alexejhero commented 1 year ago
ScrubN commented 1 year ago

Honestly, it would be nice if we brought back dependency injection. I would like to add a debug window to allow for modifying values without restarting the game and the ability to inject a settings object on every match would be much more elegant than coupling every handler component to the debug window.

The other option is to make the relevant members public or use reflection, which would also be less work.

ScrubN commented 1 year ago

In hindsight, dependency injection won't entirely solve this issue. For example if I want to add a button to force restart the pathfinding method because it stopped for whatever reason, I will either need to make the method public or use reflection.

Alexejhero commented 1 year ago

I have a debug window implemention that I can copy paste from a different mod, I will add that and then we can fill it with useful methods