"LGTM!"

[Alexejhero]

Vedal let me out please it's cold down here

---

Changes made in this pull request

• Use Protobuf instead of JSON for serialization
• Make PathfindingHandler a singleton and run it on separate thread
• Create unstable collections, each element has a UnityEngine.Object anchor, if that is destroyed then the element is automatically removed from the collection
• Split VisionHandler into OtherPlayersRecorder and DeadBodiesRecorder monobehaviours
• Split ImpostorHandler into MapDataRecorder and other excluded class
• Add Event system for GameStarted, MeetingStarted and MeetingEnded events so we dont need 100 patches for the same thing
• Create InteractionsHandler
• Record task data for all tasks + sabotage
• Make socket connection resilient to disconnects and run on separate thread
• Other random stuff, pretty much a rewrite of 70% of the codebase, this list isn't even exhaustive

---

❗ Neural network broken, pls fix

---

Co-authored by @alekso56

Closes #14 Closes #29 Closes #36

[alekso56]

When socket is not connected on startup, the player is forced to walk down forever.

[Alexejhero]

When socket is not connected on startup, the player is forced to walk down forever.

That was on purpose to test the movement handler, but it's been removed since.

The python side has not been updated to integrate with the new socket serialization system anyway.

[alekso56]

Im curious, if you are going to send partial strings anyways, why not make a data class and then send that as json then decode as json on python side?

[Alexejhero]

Im curious, if you are going to send partial strings anyways, why not make a data class and then send that as json then decode as json on python side?

JSON has a lot of fluff (for example the name of the keys is repeated in every object) so it's very inefficient for socket purposes. Additionally, since we want to be saving this data to a file, we want the file to be as small as possible.

[alekso56]

maybe can do something like this on python side, com protocol is currently sending zero data from the client, so might want to fix that first.

from dataclasses import dataclass

from numpy import byte

from bytechomp import Reader

@dataclass
class PositionData:
    TotalDistance: float
    NextNodePositionX: float
    NextNodePositionY: float

@dataclass
class DeadBodyData:
    ParentId: byte
    LastSeenPositionX: float
    LastSeenPositionY: float
    FirstSeenTime: float
    NearbyPlayersCount: byte
    NearbyPlayers: list[byte]

@dataclass
class DoorData:
    position: PositionData
    IsOpen: bool

@dataclass
class VentData:
    position: PositionData
    ConnectingVentsCount: byte
    ConnectingVents: list[PositionData]

@dataclass
class OtherPlayerData:
    id: byte
    LastSeenPositionX: float
    LastSeenPositionY: float
    LastSeenTime: float
    TimesSawVent: byte
    RoundTimeVisible: float
    GameTimeVisible: float

@dataclass
class Frame:
    seenBodiesCount: byte
    seenBodies: list[DeadBodyData]
    DidKill: bool
    SabotageUsed: byte
    DoorsUsed: byte
    DidReport: bool
    DidVent: bool
    NearbyDoorsCount: byte
    NearbyDoors: list[DoorData]
    NearbyVentsCount: byte
    NearbyVents: list[VentData]
    LastSeenCount: byte
    LastSeen: list[OtherPlayerData]

def read(stream):
    print("Creating frame from byte array")
    reader = Reader[Frame]().allocate()
    if reader << stream.read(512):
        # construct dataclass
        my_struct = reader.build()
        reader.clear()
        return my_struct

[Alexejhero]

This PR will be ready for a re-review once I've added deserialization on the python side

[Vedal987]

idk probably fine