Separate plugin functionality and do some code cleanup

VedalAI / neuro-amongus

Among Us Plugin for Neuro-sama

GNU General Public License v3.0

540 stars 49 forks source link

Separate plugin functionality and do some code cleanup #9

Closed Alexejhero closed 1 year ago

Alexejhero commented 1 year ago

Closes #4

I am opening this draft PR in advance to receive individual feedback for separate commits as I am working on restructuring the project.

The larger commits include a description of the individual changes that were made.

The plan for separating functionality is to use MonoBehaviours and dependency injection.

Changes made in this pull request

Updated dependencies to the latest version
Implemented dependency injection
Removed basically everything from NeuroPlugin.cs
... (will add later)

JohnyDaison commented 1 year ago

So you don't plan to merge this PR at all? There will be smaller PRs with parts of these changes? Because this is getting too big to properly review.

Alexejhero commented 1 year ago

So you don't plan to merge this PR at all? There will be smaller PRs with parts of these changes? Because this is getting too big to properly review.

No, I plan to merge this PR obviously. Once I test it then it will be ready for merge, but I will want for #7 and #8 to be merged before so I can handle merge conflicts. As for the review, you can review this PR on a commit-by-commit basis.

Vedal987 commented 1 year ago

Apologies for the force push, feel free to reopen or create a new PR with these changes.