VedantAnand17 / Web3-Wallet

https://web3-wallet-phi-brown.vercel.app
6 stars 35 forks source link

Added DAppBrowser and Navbar #20

Closed ayush-848 closed 1 month ago

ayush-848 commented 1 month ago

Closes #15 image

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 4:49pm
ayush-848 commented 1 month ago

@VedantAnand17 please check I created a home component to and had to rearrange the props

VedantAnand17 commented 1 month ago

Good work man 👏 What I meant to say by NavBar was kindly edit the option on top to navigate between home page and dApp browser, kindly rectify it and also check the responsiveness :)

ayush-848 commented 1 month ago

Good work man 👏 What I meant to say by NavBar was kindly edit the option on top to navigate between home page and dApp browser, kindly rectify it and also check the responsiveness :)

Should i remove the home about options from navbar

ayush-848 commented 1 month ago

image @VedantAnand17 see this

VedantAnand17 commented 1 month ago

Kindly comment out the service and contact pages :)

ayush-848 commented 1 month ago

Kindly comment out the service and contact pages :)

image done @VedantAnand17

VedantAnand17 commented 1 month ago

NavBar is unresponsive and has no home button 😅

ayush-848 commented 1 month ago

NavBar is unresponsive and has no home button 😅

@VedantAnand17 Oh i forgot about the responsive ness and the logo is the home button itself

VedantAnand17 commented 1 month ago

UX of home as logo is not good, kindly make a simple anchor for it :) (You can use the commented out Home anchor )

ayush-848 commented 1 month ago

UX of home as logo is not good, kindly make a simple anchor for it :) (You can use the commented out Home anchor )

Should I remove the logo or Add a Home button or home link beside the DAppBrowser button @VedantAnand17

ayush-848 commented 1 month ago

Now check

ayush-848 commented 1 month ago

@VedantAnand17 please merge it if it is ok

VedantAnand17 commented 1 month ago

Testing

ayush-848 commented 1 month ago

@VedantAnand17 add the labels in the PRs too, else they don't get counted