search

VedantParanjape / esp-epaper-display

ESP-IDF component for waveshare epaper displays
Other
25 stars 16 forks source link

SPI Fails for new ESP-IDF #4

Closed IsaacNez closed 1 year ago

IsaacNez commented 1 year ago

Hi,

First, thanks for this amazing port! It saved me a lot of headaches. For the past year, I have been using it over ESP-IDF v4.3 and v4.4.2 but I had to do some minor changes to make it run.

First, the includes for epdif.h and other alike had to be changed to epdif.cpp and similar. Likewise, I had to remove the definiton of SPI_HOST because it is now defined under spi_types.h

It would be my privilege to contribute to the project. I have already fixed them on my local branch but I lack the permissions to push it to the repo and then open a pull request.

I also plan to introduce version checking to make it more adaptable.

Let me know if you are interested!

VedantParanjape commented 1 year ago

Hey Thanks for the kind words, I'm glad it helped.

You can fork my repo and then push the changes to the repo. After this open a PR. Let me know if you need any more help.

cefoot commented 1 year ago

@IsaacNez could you make you changes available or describe in more detail what you did? Especially I don't know what you mean by "First, the includes for epdif.h and other alike had to be changed to epdif.cpp and similar"

IsaacNez commented 1 year ago

Hi @cefoot, I have made the changes available on #5. Sorry for not doing it sooner, I have had quite busy weeks.

VedantParanjape commented 1 year ago

Closing this as solved, thanks for the PR @IsaacNez