StefanZ8n commented 4 years ago

Pull Request Template

By contributing, you agree that your contributions will be licensed under the projects original open source license.

Description

Customer had an issue with more SAP services running on the same machine (listed in sapservices file) and had errors in the pre-script with the previous auto-detection of HANA systems. The regex change searches for the HDB string which HANA databases have in the sapservices file and introduces brackets to the sub-expression, so that the initial | does not include the first part of the upper regex.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Partner tested in customer environment where script previously failed by detecting the other SAP services, too, now it only detects the HDB.

Checklist (check all applicable):

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard to understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

tsightler commented 4 years ago

Shouldn't this change also be made to post-thaw script as well?