Veeupup / naive-query-engine

A Toy Query Engine & SQL interface
Apache License 2.0
64 stars 7 forks source link

impl display for logicalplan #49

Closed GanZiheng closed 2 years ago

GanZiheng commented 2 years ago

Signed-off-by: GanZiheng ganziheng98@gmail.com

Veeupup commented 2 years ago

try make lint before push

Veeupup commented 2 years ago

I have tried it locally, seems amazing, how about eating MaLaXiangGuo at 18:00? @GanZiheng

GanZiheng commented 2 years ago

I have tried it locally, seems amazing, how about eating MaLaXiangGuo at 18:00? @GanZiheng

No problem!

Veeupup commented 2 years ago

image maybe we can avoid print source table data in logical plan. This is when I add a line in db.rs and cargo run

impl NaiveDB {
    pub fn run_sql(&self, sql: &str) -> Result<Vec<RecordBatch>> {
       ...
        // 3. optimize
        let optimizer = Optimizer::default();
        let logical_plan = optimizer.optimize(logical_plan);
        println!("{}", logical_plan);
...
    }