search

VegeWaterDynamics / motrainer

Distributed Measurement Operator Trainer for Data Assimilation Applications
https://vegewaterdynamics.github.io/motrainer/
Apache License 2.0
2 stars 0 forks source link

93 train test split #98

Closed rogerkuou closed 10 months ago

rogerkuou commented 10 months ago

fix #93

rogerkuou commented 10 months ago

Hi @SarahAlidoost, when you have time, could you please review this one for me? Thanks!

rogerkuou commented 10 months ago

@rogerkuou thanks, looks good 👍 , just some refactoring suggestions. One more thing, in the exploration notebook, there is only one example with split argument. Can we have one example with mask too?

Thanks @SarahAlidoost ! I updated the exploration notebook with an mask option. Will add this to the incoming documention