search

Veil-Project / veil

Veil-Project
MIT License
118 stars 91 forks source link

Wrong warning showed to user when encrypting wallet? #1000

Closed us77ipis closed 1 year ago

us77ipis commented 2 years ago

Description

If I understood correctly our recent discussion on discord, the warning that is shown to the user when encrypting a wallet If you encrypt your wallet and lose your passphrase, you will LOSE ALL OF YOUR Veil! is wrong, since you can always recover everything using the seed words that you backed up during wallet creation.

Expected behavior

No misleading warning, that might lead the user to think he is doing something wrong when encrypting his wallet.

Actual behavior

screenshot

Wallet version

Current master branch

ohcee commented 1 year ago

I changed the warning so it does not seem so doom and gloom for encrypting your wallet. issue#1000

seanPhill commented 1 year ago

Thanks! Elsewhere I am sure that users are told they can always restore their coins with the seed words, (although it can be a lot more work to do so than with a Bitcoin wallet), but it is good to fix it here. Next update I will check that we have that fixed, if you haven't already made a PR for it.

seanPhill commented 1 year ago

Done. :) Just hope that everyone does not lose their passphrase, as well as does not lose their seed phrase.