search

Veil-Project / veil

Veil-Project
MIT License
117 stars 91 forks source link

Further enhancement of the Zerocoin minting screen or page, following the merge of the automintoff default now preventing unplanned autominting #1030

Open seanPhill opened 1 year ago

seanPhill commented 1 year ago

People are still understandably not fully informed about the operation of the Zerocoin Minting page in the Veil core wallet.

It should be more intuitive and contain explanations that do not require users to look for Frequently Asked Questions, within the wallet or on a Support Desk website, or in a community forum such as on Discord.

I will attach a screenshot and annotations that will explain what I am looking for, which was based on the most recent Pull Request #1028 just a few hours ago, built by the Github Actions automated build for macOS.

Zerocoin Minting Page proposed enhancements

seanPhill commented 1 year ago

The possible changes include:

  1. Explanations either on screen or under a (?) clickable icon explaining
    • Note: Autominting only works if turned on, and if some basecoin balance exists. Autominting automatically from basecoin is no longer the default secure procedure. Manually mint from RingCT instead.
    • Further note, when basecoin IS present, but a larger balance is in RingCT it WILL MINT automatically (the maximum number of nine eg. 90000 in 10Ks) from RingCT.
    • About the [Mint] button, it might be good, rather than someone's suggestion of having a [mint] button for each balance to include an explanation that:
    • "If 'use basecoin' is not ticked, the minting function will first check RingCT, and if the required balance is not there it will try the CT balance.
    • "You can simply hit [Enter] instead of the button, if you like."
  2. Where it says "AUTOMINTING is now OFF." This is just boilerplate text. It won't change when autominting is actually turned on by someone setting automintoff=0 in the veil.conf configuration file. The simplest way to change this is to change the sentence from "AUTOMINTING is now OFF." to "AUTOMINTING is now OFF BY DEFAULT." A nicer way would be to check the actual state and change the text to "AUTOMINTING is now ON." if it is actually ON!
  3. The red text that says "Automint control setting has been given to your Veil configuration file" I would recommend that that string, or at least the "Veil configuration file" part become a clickable link to the procedure that launches veil.conf in your default text editor that is otherwise launched by clicking text in the Settings, Options, Preferences dialog.
MatWaller commented 2 months ago

I could work on some of these perhaps?