Veil-Project / veil

Veil-Project
MIT License
118 stars 91 forks source link

Issue#976 dumpwallet #1031

Closed ohcee closed 1 year ago

ohcee commented 1 year ago

Problem

dumpwallet and dumpprivkey cannot be used as a backup for stealth addresses. There is no warning regarding this.

Root Cause

Hasn't been added to wallet.

Solution

This PR leaves the note Note: dumpwallet does not include private keys for stealth addresses. Use wallet.dat file or seed words for complete backup. in the help dumpprivkey and help dumpwallet as well as the dumped .dat file.

Bounty PR

976

Bounty Payment Address

sv1qqpy56fkfmkffp44q8tjx6scldglaf5qqkwsv3lzd440z9vh6d8y9hcpqts3u7xpwt92gxsyr0n42c228n6j5cczzvrget8hhzyfrq7qydv05qqqr7s9z5

Unit Testing Results

Tested on MacOS

dumpwallet dumpprivkey wallet dat

sinetek commented 1 year ago

Textual changes. Looks good to me.