search

Veil-Project / veil

Veil-Project
MIT License
118 stars 91 forks source link

Fix compilation under gcc 13 #1039

Closed sinetek closed 1 month ago

sinetek commented 9 months ago

These changes were required on my machine. Add include for std::runtime_error, and add include for uint8 Additionally this adds a patch for Qt that adds some limits stuff like std::max.

ohcee commented 7 months ago

utACK Looks fine to me.

seanPhill commented 7 months ago

I noticed

https://github.com › bitcoin › bitcoin › pull › 25719 build: Bump Qt to 5.15.5 in depends #25719 27 Jul 2022 Bumping Qt patch version allows to drop the fix_limits_header.patch. Guix builds on x86_64: 6e403f6442f904a17e00f2c5d539c38a6d736963deaca080aaf7e45911f32cd4 guix ...

but as noted in the patch "- Qt 5.15 -- unavailable as open source" this patch looks appropriate, and also as it must have been used in Bitcoin core too. However, 5.15.5 might have solved the lack of open source issue? …

seanPhill commented 4 months ago

If there are no objections I will push this to master, the next time I look at this.