search

Veil-Project / veil

Veil-Project
MIT License
117 stars 91 forks source link

Veil granularity and wall-clock time adjustments for 60 second block times from Bitcoin's 600. #700

Open mimirmim opened 4 years ago

mimirmim commented 4 years ago

The issue is that this, among many others, our timing is correct for Bitcoin in many instances, and not for Veil. Veil is every 60 seconds per block per Bitcoin's 600 seconds per block. Times need to be adjusted.

A specific example is that in CTxIn, nSequence lock-time granularity is incorrectly set for Bitcoin's block-time to seconds.

Another example is that we are set for only holding the past few hours or blocks, not 2 days by default for pruned nodes.

This serves to set as to investigate and find many of these block related time issues and then fix them in a future pull request. The below list will be updated as more are found.

TO UPDATE:

CaveSpectre11 commented 4 years ago

@mimirmim added a note regarding the retransmission timer to be scaled properly.