search

Veil-Project / veil

Veil-Project
MIT License
118 stars 91 forks source link

[GUI] add link to encrypt wallet and console #918

Open codeofalltrades opened 3 years ago

codeofalltrades commented 3 years ago

image

Two things that would be nice to have but definitely not necessary for merging:

It would be cool if "Encrypt Wallet" was a hotlink that popped up the Encrypt Wallet popup
Likewise, if the reference to the debug console also was a hotlink

ref: https://github.com/Veil-Project/veil/pull/900#pullrequestreview-616915374

Rock-N-Troll commented 3 years ago

Also, shouldn't the wallet automatically create a basecoin address on first startup? What is the disadvantage of doing that?

CaveSpectre11 commented 3 years ago

Also, shouldn't the wallet automatically create a basecoin address on first startup? What is the disadvantage of doing that?

That was intentional with the initial intent to not encourage basecoin use. There is an active effort to integrate basecoin control into the gui, which this would be an appropriate addition to that, but in regards to this PR, it is decidedly out of scope.