[Wallet][Consensus] Resolve misc clang lock annotation warnings. - Githubissues

Veil-Project / veil

Veil-Project

MIT License

117 stars 91 forks source link

[Wallet][Consensus] Resolve misc clang lock annotation warnings. #952

Closed Zannick closed 3 years ago

Zannick commented 3 years ago

Problem

Building with clang results in lots of warnings about lock annotations not being obeyed.

Solution

Follow instructions on warnings:

Replace double lock of cs_main with an assertion.
Reorganize code to release cs_main before calling blockheaderToJSON.
Lock cs_main before calling any of: GetBlocksToMaturity, GetAddressBalances, IsSpent, TestBlockValidity.

Tested

Configured with --with-sanitizers=thread, built with clang, run on regtest.

codeofalltrades commented 3 years ago

@CaveSpectre11 is your review a NIT or need to change?