When dealing with some orphan transactions[^1], some addresses aren't in the address map, and so when we look them up we get an invalid return value to indicate we didn't find it. However, we don't check for the sentinel value and instead try to look up its type (it's a boost::variant) which can assert with forcedreturn if the `which` field is outside the valid range.
[^1]: This only happened for me for months-old orphan blocks, and I can't tell if the address never existed or if it got corrupted at some point.
Fix
We don't need to look up an address in the map when all we're going to do is use the key (which must be the same type per boost::variant).
Issue
When dealing with some orphan transactions[^1], some addresses aren't in the address map, and so when we look them up we get an invalid return value to indicate we didn't find it. However, we don't check for the sentinel value and instead try to look up its type (it's a
boost::variant) which can assert with forcedreturn if the `which` field is outside the valid range.[^1]: This only happened for me for months-old orphan blocks, and I can't tell if the address never existed or if it got corrupted at some point.
Fix
We don't need to look up an address in the map when all we're going to do is use the key (which must be the same type per
boost::variant).Tested
Windows 10 mainnet wallet.