search

VeinsOfTheEarth / RivGraph

Extracting and quantifying graphical representations of river and delta channel networks from binary masks
https://veinsoftheearth.github.io/RivGraph/
Other
81 stars 24 forks source link

Brokenbuild #76

Closed jsta closed 2 years ago

jsta commented 2 years ago

With these changes, the run at least gets past the conda build stage and runs the tests. #74

elbeejay commented 2 years ago

I think we should merge this as at least the ubuntu + docs builds work. Future attempts to fix the continuous integration pipelines could then build off of this. What do y'all think @jsta @jonschwenk?

jsta commented 2 years ago

I've seen a lot of recent activity in the shapely/fiona/geopandas conda-forge feedstocks. Although I think it's unlikely, it's possible the errors have been fixed upstream...

jsta commented 2 years ago

I re-ran the build and now Ubuntu also seems broken.

jsta commented 2 years ago

The CI is failing just because the conda env solve timesout. The PR installs and tests fine for me on local Ubuntu and Windows setups so best idea I have to to use a lock file to speed up the solve https://github.com/conda-incubator/conda-lock

I don't have a local Mac setup so I can't make a lockfile for it.

jsta commented 2 years ago

@elbeejay @jonschwenk Got tests to pass using the Lockfile strategy!

elbeejay commented 2 years ago

Wow @jsta that's fantastic, thanks for figuring it out!