search

VeinsOfTheEarth / rabpro

Delineating watershed basins and computing attribute statistics using Google Earth Engine
https://VeinsOfTheEarth.github.io/rabpro
BSD 3-Clause "New" or "Revised" License
35 stars 8 forks source link

Unpin geopandas and pin pyproj #137

Closed tzussman closed 2 years ago

tzussman commented 2 years ago

Resolves #53

jonschwenk commented 2 years ago

Can we force the build check before merging this? I just want to make sure it doesn't break the build.

jsta commented 2 years ago

We can have the CI build run if we add environment.yml to the watched paths here https://github.com/VeinsOfTheEarth/rabpro/blob/main/.github/workflows/build.yaml#L14

tzussman commented 2 years ago

Ran it in my fork: https://github.com/tzussman/rabpro/runs/7469745944 Passes on macOS, but not Ubuntu... will try to investigate some more

jonschwenk commented 2 years ago

@tzussman any updates on the Ubuntu build?

tzussman commented 2 years ago

I ran this locally on my Linux VM and everything was fine, but the Github build still didn't work... I'm really not sure why it worked locally but not in actions, but I changed from using miniconda to using mamba in 1d0ede0, which seemed to make everything work (see run in my fork)

jsta commented 2 years ago

I'll try creating the env on my local Ubuntu machine. I say if that's successful we merge.

jsta commented 2 years ago

Works on my machine, fingers crossed it also works for conda-forge