search

Vekseid / ForumSessionProvider

MediaWiki extension to use Elkarte and SMF as a session provider, allowing single-sign on in versions 1.27+
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

Changes #1

Closed jdarwood007 closed 4 years ago

jdarwood007 commented 4 years ago

Revamped the ForumSessionProvider and tested on both SMF 2.0 and 2.1. Added backwards compatibility with the old Auth_SMF.php plugin.

Signed-off-by: jdarwood007 unmonitored+github@sleepycode.com

jdarwood007 commented 4 years ago

I haven't wrote many pdos, so yea.

Don't have a postgresql anymore but it should work from what I read.

Vekseid commented 4 years ago

Alright, I'm going to put your version through some live testing and see how it goes.

Thank you. : )

Vekseid commented 4 years ago

Few more comments.

In any case, this isn't working for me, in SMF 2.0 or in Elkarte. I need to dig down deeper into this, or maybe ask you to split up the changes so we can test and apply things in a saner fashion.

jdarwood007 commented 4 years ago

Your welcome to close this PR if you feel its not needed anymore. Did a merge but kept my changes and fixed a few things that I saw could be wrong.

Vekseid commented 4 years ago

It is getting rather hard for me to make sense of. Some things got clobbered, I can tell.

If there's anything specific you see, please feel free to submit specific PRs or open issues for them. Your caching changes at least still need to make it in, though I can do that once I've got a proper environment for it.

In any case, thank you for your help. : )

jdarwood007 commented 4 years ago

The caching is one change. I'm testing on 1.31 as its the current LTS, if your testing against something older you should change that: https://www.mediawiki.org/wiki/Version_lifecycle I need to test against 1.35 as well soon.

The only other big difference here is I'm putting everything into FSSettings and using that rather than globals or a bunch of local variable calls. Just cleaned up a lot of stuff.