[Windows] Game crashes when match starts with yapb installed.

[CortexReaver]

Installation of yapb was done by this guide: https://yapb.readthedocs.io/en/latest/installation.html#installing-bot-on-windows I can join team and chose class perfectly fine (through a console with jointeam and joinclass commands correspondingly), but when match is about to begin I get this (right after 00:01 on the timer):

Game is filling all available player slots with bots, and it seems they are running around the map perfectly fine too until the match starts.

[a1batross]

This looks like an engine bug.

[a1batross]

@jeefo

uint8_t *Game::getVisibilitySet (Bot *bot, bool pvs) {
   if (is (GameFlags::Xash3D)) {
      return nullptr;
   }

BUT WHY?

[jeefo]

there was assertion failure on old engine. not sure about new engine.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

---

From: Alibek Omarov @.> Sent: Thursday, June 15, 2023 6:31:43 PM To: Velaron/cs16-client @.> Cc: jeefo @.>; Mention @.> Subject: Re: [Velaron/cs16-client] [Windows] Game crashes when match starts with yapb installed. (Issue #43)

@jeefohttps://github.com/jeefo

uint8_t Game::getVisibilitySet (Bot bot, bool pvs) { if (is (GameFlags::Xash3D)) { return nullptr; }

BUT WHY?

— Reply to this email directly, view it on GitHubhttps://github.com/Velaron/cs16-client/issues/43#issuecomment-1593297035, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AANS4YQSQYMXTARIUNGGLV3XLMTF5ANCNFSM6AAAAAAZIALWXM. You are receiving this because you were mentioned.Message ID: @.***>

[jeefo]

Well, new engine still asserts, just the version of bot that is currently in releases can't detect new engine properly.

@CortexReaver install yapb from actions build: https://github.com/yapb/yapb/actions/runs/5269798983

[a1batross]

@jeefo the thing is, we care about mod compatibility. It's better to fix engine because such bug may occur in the other mods.

[a1batross]

https://github.com/FWGS/xash3d-fwgs/issues/834 and it sure does!

[jeefo]

Ah, i had to report it years ago, Some yapb version didn't had PVS/PHS checks enabled and worked ok. When it's was re-enabled old engine was already archived and i just forgot about it.

[a1batross]

I pushed an engine fix for this. https://github.com/FWGS/xash3d-fwgs/commit/4c02c255065e28938af35a2f1930495c090fdfdd

This probably can be back ported to the old engine as well. cc @tyabus