search

Velfi / i-ching

A library for i-ching apps written in Rust, and a companion CLI app for divination
Other
24 stars 9 forks source link

True up changing lines using index shim #5

Closed krry closed 5 years ago

krry commented 5 years ago

There was one last little discrepancy after I flipped the order of the cast lines: the changing lines are labeled 1-6 in the json data, and the index of the line_meaning.position starts at 0 and goes to 5. Rather than mess with the data, I thought a little index shim, though it feels a bit hacky, was prudent. And now the changing lines are spot on, just like I was drawing the lines by hand :)

Velfi commented 5 years ago

Great work Kerry, thanks. One thing though: I'd prefer to move this fix src/bin/hexagram_json/mod.rs#L122 to src/hexagram.rs#L91 by adding 1 to the line position index instead of subtracting. I'll merge your fixes, makes that one alteration, and then release a new version on crates.io.

krry commented 5 years ago

Super cool! Thanks for playing with me. Today I found an I Ching android app called Deepware Changes that is so full-featured and engrossing. Randomness algorithms that accept accelerometer input (coin tosses), multiple sources (Wilhelm, Legge, etc). Now I'm thinking about I Ching chat bots for Slack and Messenger. Any interest in collaborating? Potentially could depend on this library.

Velfi commented 5 years ago

I'd be happy to provide support for this library but I have too many other projects to pick up another one. Sorry. This project is open source so you're welcome to use it for whatever you like so long as you include the license notice in your project.