This PR adds streaming support for multi-property installations.
I could have unified the events_ and events_intraday_ code in the combine_property_data macro a little more writing both to events_* tables because, as things are currently written, daily and streaming frequencies are mutually exclusive and saved a couple lines of code. However, it is likely that supporting the daily+streaming frequency will require separation of code and it is easier to debug when they write to events_ and events_intraday_ code.
Checklist
[ y] I have verified that these changes work locally
[ y] I have updated the README.md (if applicable)
[ ] I have added tests & descriptions to my models (and macros if applicable)
[ y] I have run dbt test and python -m pytest . to validate existing tests
Look good. I didn't think it would be that easy. I guess daily+streaming would be hard because you'd have to juggle the fact that the streaming data is eventually merged into the daily data.
Description & motivation
This PR adds streaming support for multi-property installations.
I could have unified the
events_
andevents_intraday_
code in thecombine_property_data
macro a little more writing both toevents_*
tables because, as things are currently written, daily and streaming frequencies are mutually exclusive and saved a couple lines of code. However, it is likely that supporting the daily+streaming frequency will require separation of code and it is easier to debug when they write toevents_
andevents_intraday_
code.Checklist
dbt test
andpython -m pytest .
to validate existing tests