Add adapter dispatch pattern for path extraction

Velir / dbt-ga4

dbt Package for modeling raw data exported by Google Analytics 4. BigQuery support, only.

MIT License

289 stars 128 forks source link

Add adapter dispatch pattern for path extraction #272

Closed adamribaudo-velir closed 9 months ago

adamribaudo-velir commented 9 months ago

Description & motivation

It can be helpful for users of the package to override the page path extraction to accommodate implementation issues. This PR applies the adapter dispatch pattern to the extract_page_path macro.

Checklist

[x] I have verified that these changes work locally
[na] I have updated the README.md (if applicable)
[na] I have added tests & descriptions to my models (and macros if applicable)
[ ] I have run dbt test and python -m pytest . to validate existing tests

adamribaudo-velir commented 9 months ago

There is an issue with the unit tests that we're working through. I'm going to merge this in the meantime.