Velir / dbt-ga4

dbt Package for modeling raw data exported by Google Analytics 4. BigQuery support, only.
MIT License
289 stars 128 forks source link

Default channel grouping not in line with GA4 default channel grouping #273

Closed erikverheij closed 7 months ago

erikverheij commented 9 months ago

Hello,

Firstly, I'd like to express my gratitude for this incredible package; it has been immensely beneficial in my work.

While reviewing default_channel_grouping.sql, I noticed that the "Paid Other" channel group, which is a default in GA4, appears to be missing. The documentation from Google Analytics for the "Paid Other" channel group is provided here: GA4 Default Channel Groups.

For reference, the "Paid Other" criteria is defined as: Medium matches regex ^(.*cp.*\|ppc\|retargeting\|paid.*)$

Upon further inspection, and while comparing with the GA4 documentation, I observed a few discrepancies:

For visual reference, please see the image provided:

image

I hope these observations prove useful, and I'm eager to contribute or assist further if needed. Thank you for your continuous effort in maintaining and improving this repository.

Kind regards, Erik

adamribaudo-velir commented 9 months ago

Very useful! Thanks so much. Do you feel comfortable submitting a PR to resolve these discrepancies?

It does make me wonder if Google changes these from time to time as I thought our implementation was correct as of ~6 months ago 🤔

erikverheij commented 8 months ago

Thanks for your reply :) I'll create a PR in the upcoming weeks!