search

Velir / dbt-ga4

dbt Package for modeling raw data exported by Google Analytics 4. BigQuery support, only.
MIT License
289 stars 128 forks source link

dbt 1.8 has deprecated `tests` in favour of `data_tests` #328

Open elyobo opened 3 weeks ago

elyobo commented 3 weeks ago

See https://docs.getdbt.com/docs/build/data-tests#new-data_tests-syntax

tests should be renamed to data_tests for future compatibility, although this is a BC break and so it's not clear at which point to make this change to me.

adamribaudo-velir commented 3 weeks ago

Working on adding unit tests here but it will take a while to migrate all of them

https://github.com/Velir/dbt-ga4/tree/feature/dbt-unit-tests

elyobo commented 3 weeks ago

I'm not suggesting a change of the test suites themselves (although adding unit tests sounds great!), just that the name of the existing tests config item has moved to data_tests and it's generating a warning because of that; works fine for now but will presumably go away in a future release.

adamribaudo-velir commented 3 weeks ago

Fair. I was going to wrap it all into 1 PR but we could update to data_tests in its own change.

elyobo commented 3 weeks ago

Probably no rush, I don't know when they'll remove them entirely but presumably a 1.9 release at least.