Velleman / python-linkplay

LinkPlay library for Python
MIT License
9 stars 4 forks source link

http only supported,. no support for https (used by the wiim devices) #19

Closed infamy closed 2 months ago

infamy commented 3 months ago

https://github.com/Velleman/python-linkplay/blob/68b43c5892d1c54a61510883ef933b9d74af4a83/src/linkplay/discovery.py#L17

If this was extended to allow passing the protocol, which would allow setting https, this would resolve the issue with wiim devices (or so I suspect). My wiim pro will only respond if it gets a request over https, and ignores http.

dukeofphilberg commented 3 months ago

With #27 this should now be possible. The HomeAssistant changes will follow in the coming days.

silamon commented 2 months ago

The pull request went in Home Assistant, closing.