Open vletoux opened 3 years ago
I found out there is a couple of checks missing.
First: https://github.com/Velocidex/WinPmem/blob/master/kernel/executable/winpmem.cpp#L422 If there is no more space on the disk, WriteFile Fails, then copy_memory fails, then write_raw_image succeed. The status is not propagated at the end of the program (the %ERRORLEVEL% var)
Second: https://github.com/Velocidex/WinPmem/blob/master/kernel/executable/main.cpp#L189 if the driver install fails, status will be negative and the program will stop. But the final status will not be propagated at the end of the program (the %ERRORLEVEL% var)
I found out there is a couple of checks missing.
First: https://github.com/Velocidex/WinPmem/blob/master/kernel/executable/winpmem.cpp#L422 If there is no more space on the disk, WriteFile Fails, then copy_memory fails, then write_raw_image succeed. The status is not propagated at the end of the program (the %ERRORLEVEL% var)
Second: https://github.com/Velocidex/WinPmem/blob/master/kernel/executable/main.cpp#L189 if the driver install fails, status will be negative and the program will stop. But the final status will not be propagated at the end of the program (the %ERRORLEVEL% var)