search

Velocidex / c-aff4

An AFF4 C++ implementation.
http://docs.aff4.org
Apache License 2.0
188 stars 34 forks source link

Reimplement AFF4Flusher for move semantic correctness #113

Closed jtsylve closed 5 years ago

jtsylve commented 5 years ago

The move semantics of AFF4Flusher are incorrect as written (Flush will not be called in all instances where it should be and can lead to leaks). For correctness (and probably performance), I've redefined AFF4Flusher as a std::unique_ptr with a custom deleter.