search

Velocidex / velociraptor

Digging Deeper....
https://docs.velociraptor.app/
Other
2.8k stars 469 forks source link

Add option to override collector filename to CreateCollector.yaml #3589

Closed menewol closed 1 week ago

menewol commented 2 weeks ago

Added a parameter to add a prefix to the filename of the collector being built. This allows the artifact to be run multiple times in a single notebook, with different configurations, and not overwrite the previously created executables.

CLAassistant commented 2 weeks ago

CLA assistant check
All committers have signed the CLA.

scudette commented 2 weeks ago

Actually there is no particular reason this has to be a prefix - maybe an override? If the user specifies an output filename then we use that otherwise we can do the default Collector + tool name?

menewol commented 2 weeks ago

Yes - thats even easier! Didnt think of this approach until now

menewol commented 2 weeks ago

reworked to override the full filename, or use the default formatting if option is not used.

menewol commented 2 weeks ago

aaaaand readded the name definition of the artifact :facepalm:

scudette commented 1 week ago

Just closing this PR in favor of #3591 because this PR did not set the "allow edits from maintaner" https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork