search

VelocityPowered / CrossStitch

A mod designed to improve compatibility with server mods and Minecraft proxies
MIT License
20 stars 11 forks source link

Breakage on Minecraft 1.19 #7

Open haykam821 opened 2 years ago

haykam821 commented 2 years ago

The mixin likely needs to be moved to the CommandTreeS2CPacket.ArgumentNode.write method. Additional logging would be beneficial here for mods that do not register their argument types to the class map because of silent breakage introduced by the argument type refactor (mods should register using ArgumentTypeRegistry instead).

Note that argument types now sync using raw IDs as well, and Velocity seems to represent crossstitch:mod_argument as the raw ID -255.

LaurenceBarnes commented 2 years ago

I got this error spamming every few seconds, could that be related? https://pastebin.com/W9npq6dV

haykam821 commented 2 years ago

Yes, that mixin error is due to the argument type refactor. The pull request #8 which I opened fixes that error by moving the serialization to the new inner class.