search

Veloxnet-LMS / moodle-block_vxg_orgs

2 stars 2 forks source link

please use contants instead of hard-coding numbers #6

Open danmarsden opened 3 years ago

danmarsden commented 3 years ago

https://github.com/Veloxnet-LMS/moodle-block_vxg_orgs/blob/6bac11442ea51c2bbead070508d3161522502caf/locallib.php#L35

It's a lot more readable/understandable to use: CONTEXT_SYSTEM, CONTEXT_COURSECAT, CONTEXT_COURSE than 10, 40, 50

note: this isn't a blocker for approval in the plugins db, but will greatly improve the readability of your code.