miohtama
commented
2 months ago Some example actions needed (to the list above):
- Deploy a vault
- Repeatable, so that you can play around with different parameters for testing (i.e. not mainnet fork)
- Uniswap v2 integration test, so there is starting point how to make trades, deposit and redeem on the behalf of users
- Example test case: Create vault, deposit from two investors w/different amounts, make a ETH/USD trade on a vault, check fees were correctly included, read the value back for two investors that should now have claim over ETH position
- Must be narrative i.e. well commented - nobody wants to reverse engineer uncommented JavaScript
- Read all deployed vaults
- Read/write vault parameters
- Owner
- Fees
- Get vault depositors
- Get vault deposit and redeem events (e.g. since block X)
- Get the vault total value (NAV)
- In USD, other currencies
- Get the vault individual balances
- Get the list of available tokens to trade
- Making a trade
- Reading all past trades
- Checking how much slippage a trade had
- Get paid fees
- Getting events when fees are paid
aj07
Velvet Integration Checklist
For integration and development, some updates are needed for external developers to integrate the Velvet codebase. The following checklist outlines the necessary improvements:
[ ] Establish a repeatable testing and development environment
[ ] Create an overview of smart contracts
[ ] Improve smart contract documentation
[ ] Provide example code snippets in developer documentation