Velvet-Capital / Velvet-v4

V4 (thena+venus) on top of v3

Other

0 stars 0 forks source link

Implement Staking Support - V3 & V4 Wrapper Contracts #42

Open langnavina97 opened 3 weeks ago

langnavina97 commented 3 weeks ago

Implement Staking Support - V3 & V4 Wrapper Contracts

Overview

Add staking capabilities through new wrapper contracts to support yield-generating opportunities through various DeFi protocols.

Current State

V4
- Supports ERC20 tokens
- Uniswap V3 LP positions
- Borrowing functionality
V3
- Basic ERC20 support only
- No staking capabilities

Technical Requirements

Core Features

[ ] Partial unstaking support (where protocol allows)
[ ] Reward distribution handling
[ ] Gas-efficient implementation
[ ] Emergency withdrawal mechanism

Architecture Requirements

Minimal impact on existing integrations
Upgradeable design?

Key Design Decisions

V3 Implementation Decision

Whether to create new staking wrapper contracts for V3
These wrappers can also be used in V4
Considerations:
- Development efficiency
- Existing V3 user base needs
- Development resources and priorities

V4 Implementation

Create new staking wrapper contracts
Protocol-specific implementations

Technical Specifications

Unstaking Strategy

Primary: Partial unstaking where supported
Fallback: Timelock mechanism
Clear indication of unstaking capabilities per protocol

Reward Distribution

Protocol-specific reward token handling
Auto-compound rewards where possible
Gas-efficient claiming process

langnavina97 commented 3 weeks ago

Discussion Outcome (Daily Stand-up, Oct 30, 2024)

Staking Implementation Strategy

UniswapV2-style Pools

Decision: No custom wrapper implementation needed
Rationale:
- Beefy Finance already provides efficient implementations for V2-style pool staking
- Would be redundant to rebuild existing, proven infrastructure
- Can leverage Beefy's battle-tested contracts instead

UniswapV3-style Pools

Decision: Proceed with custom wrapper implementation
Rationale:
- Critical for protocols with staking capabilities (e.g., Aerodrome)
- Asset managers need flexibility in setting custom ranges for fee optimization
- Custom ranges enable different risk/reward profiles that aren't possible with fixed-range implementations from other protocols