[FEATURE] Add OnNewGame events in SaveGame helper

Ven0maus / SOD.Common

A common library for shadows of doubt modding.

MIT License

4 stars 4 forks source link

[FEATURE] Add OnNewGame events in SaveGame helper #6

Closed ReveredRedHood closed 10 months ago

ReveredRedHood commented 10 months ago

Needs in-game testing.
Please check that pulling out the InitializeTime logic was correct to do (that it should run for both loading a game and starting a new game).
Still need to update changelog etc.

Ven0maus commented 10 months ago

The InitializeTime is fine in NewGame as you did it, good spot!, In theory its not needed for the initial new game (but doesn't hurt), but its required when you make a new game from within an ongoing game (time data should be reset).

ReveredRedHood commented 10 months ago

OK, it actually wasn't working the way I had it before, but I've fixed it. I tested the fix in-game and it should be good. Check that the CityConstructor_StartLoading logic still works with the call to Lib.Time.InitializeTime... you could pull the InitializeTime static function in the patch class back into the prefix if you prefer.

Ven0maus commented 10 months ago

Looks good!