Venafi / VenafiPS

Powershell module to fully automate your Venafi TLS Protect Datacenter and Cloud platforms!
https://venafips.readthedocs.io/
Apache License 2.0
17 stars 8 forks source link

New-VcConnector manfest change fix #282

Closed gdbarron closed 1 month ago

gdbarron commented 1 month ago
gdbarron commented 1 month ago

Successfully tested New-VcConnector and Set-VcConnector commands.

Note that when using an existing connector name, an http "500" error is returned, but no clear error pointing to the problem.

New-VcConnector : {"errors":[{"code":16004,"message":"Unable to create new plugin."}]}
At line:1 char:1
+ New-VcConnector -ManifestPath C:\tmp\manifest.create.json -Verbose
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [New-VcConnector], WebException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,New-VcConnector

Thanks for this feedback. This is what the api is giving us so perhaps we can suggest they enhance the error message.

astro2000j commented 1 month ago

Successfully tested New-VcConnector and Set-VcConnector commands. Note that when using an existing connector name, an http "500" error is returned, but no clear error pointing to the problem.

New-VcConnector : {"errors":[{"code":16004,"message":"Unable to create new plugin."}]}
At line:1 char:1
+ New-VcConnector -ManifestPath C:\tmp\manifest.create.json -Verbose
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [New-VcConnector], WebException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,New-VcConnector

Thanks for this feedback. This is what the api is giving us so perhaps we can suggest they enhance the error message.

That’s why I chose to approve rather than block it based on the return. Better to have the endpoint supply the reason than taking the time to work out the logic on our side.