search

Venafi / terraform-provider-venafi

HashiCorp Terraform provider that uses Venafi to streamline machine identity (certificate and key) acquisition.
https://www.terraform.io/docs/providers/venafi/
Mozilla Public License 2.0
16 stars 20 forks source link

feat(timeout): use timeout from plugin SDK #107

Open jaikanthjay46 opened 1 year ago

jaikanthjay46 commented 1 year ago

Description

Adds the ability to specify terraform native timeout config so that it can be overridden. Closes #80

I wrote this code sometime back but was unable to get unit tests running successfully. There is some kind of mock bundle needed I guess.

forevergenin commented 1 year ago

This PR is open and under review for quite sometime. Are there any challenges with getting this merged ?

forevergenin commented 1 year ago

@tr1ck3r can you help with this PR ?

luispresuelVenafi commented 1 year ago

HI @forevergenin

Thank you for reaching out and @jaikanthjay46 for his contribution, all of these are welcome for our Open Source integrations. @tr1ck3r is no longer an active contributor to our Open Source products. Effectively, you should reach out to our default users set, currently, when a PR is created. That said I'll bring this up with my manger so we can size this work and plan when can this be integrated into a sprint so we can get it merge. There's some QA process we need to get code merge, especially if from external. Thank you for you patience and understanding! :)

forevergenin commented 1 year ago

Thanks for the quick response @luispresuelVenafi ! Appreciate you taking time to set the context.