search

Venafi / vault-pki-backend-venafi

Venafi PKI Secrets Engine plugin for HashiCorp Vault that enables certificate enrollment using Venafi machine identity services.
Mozilla Public License 2.0
54 stars 19 forks source link

Fix build with latest Vault SDK and go-plugin #124

Closed swenson closed 1 year ago

swenson commented 1 year ago

Fixes #121

luispresuelVenafi commented 1 year ago

Hi there @swenson,

there's already work on this (which also does the same, I also deleted the vendor folder to be out of the project as also believe we don't to commit it anymore). I started this PoC last week: https://github.com/Venafi/vault-pki-backend-venafi/compare/bumping-vault-sdk-v1-13-2

It's still on the works because there's still testing we need to do.

swenson commented 1 year ago

Cool @luispresuelVenafi. Should I delete this or keep it open?

luispresuelVenafi commented 1 year ago

@swenson let's keep it open until any of the branches for this change gets merged. I'll check the differences between this one and mine's.

luispresuelVenafi commented 1 year ago

Closing as: vendor removal was attended on: https://github.com/Venafi/vault-pki-backend-venafi/pull/126 and upgrading the Vault SDK is being attended, at the moment of this comment, in: https://github.com/Venafi/vault-pki-backend-venafi/pull/128