search

Venafi / vault-pki-monitor-venafi

Venafi PKI Monitoring Secrets Engine for HashiCorp Vault that enforces security policy and provides certificate visiblity to the enterprise.
Mozilla Public License 2.0
19 stars 9 forks source link

Upstream functionality #2

Closed jefferai closed 4 years ago

jefferai commented 5 years ago

Is there a reason to fork the entire plugin rather than see if the functionality can be upstreamed?

tr1ck3r commented 5 years ago

Hi @jefferai, Ultimately our preference is to have this functionality upstreamed to the Vault repo. We forked the PKI backend to simplify development/testing efforts and because we want to make this functionality available to our mutual customers whether or not it can be upstreamed. Okay if I contact you once we have a final release and would be ready to submit a pull request?

jefferai commented 5 years ago

That sounds good, although if you are planning to upstream it I'd suggest working on the design with us ahead of finalizing it yourself. That way if there are concerns that need to be addressed, you don't need to either maintain a fork, or do a lot of rewriting on your end.

tr1ck3r commented 4 years ago

I'm currently coordinating with Marshall Copeland on the next steps for upstreaming this project into Vault.