feat: automatically kill and restart discord

Vencord / Installer

A cross platform gui/cli app for installing Vencord

GNU General Public License v3.0

491 stars 66 forks source link

feat: automatically kill and restart discord #131

Open SunsetTechuila opened 1 month ago

SunsetTechuila commented 1 month ago

tested on:

Windows (Stable Discord)
Ubuntu (Discord installed from Flatpak)

binaries - https://github.com/SunsetTechuila/Installer/releases/tag/v1.5.0

sh -c "$(curl -sS https://raw.githubusercontent.com/SunsetTechuila/Installer/script/install.sh)"

Vendicated commented 4 weeks ago

what's the use case?

SunsetTechuila commented 4 weeks ago

installing/repairing vencord and openasar kills the discord process, so i have to open the start menu every time to restart it, which is not very convenient

i'm also going to the add ability to combine commands, and with that it will be possible to run VencordInstallerCli -repair -install-openasar -launch-discord -branch auto after the update and have discord patched and running

Vendicated commented 4 weeks ago

I don't think that's very useful. it would be way better to instead:

implement killing logic on linux and mac and do it before patching
remember if discord was killed and if yes relaunch it after patching is done

SunsetTechuila commented 4 weeks ago

remember if discord was killed and if yes relaunch it after patching is done

sounds good to me, will rework this pr

SunsetTechuila commented 4 weeks ago

@Vendicated ready for review

idk how to launch discord installed from flatpak

SunsetTechuila commented 3 weeks ago

idk how to launch discord installed from flatpak

fixed