search

Vencord / Vesktop

Vesktop is a custom Discord App aiming to give you better performance and improve linux support
GNU General Public License v3.0
3.74k stars 181 forks source link

High-Pitched Sound During Calls #317

Open Plarpoon opened 8 months ago

Plarpoon commented 8 months ago

Environment:

Description:

During calls, other participants occasionally experience an extremely loud and high-pitched sound. This issue has persisted across the last two versions of the program.

Reproduction Steps:

  1. Join a call.
  2. Engage in conversation until the high-pitched sound occurs.

Additional Information:

A clip of the sound has been uploaded to YouTube. Note that the original sound is significantly louder, but the platform has automatically normalized the audio levels. YouTube Link. This noise doesn't reproduce itself only once but at several moments during a regular an hour talk, it sounds like something minor but unfortunately it really hurts the ears of the people I talk with.

Troubleshooting Attempts:

Active Plugin List:

Request:

Please investigate this issue. I will provide additional information as needed.

AAGaming00 commented 8 months ago

Have you used discord-screenaudio recently? it used to cause this issue system-wide for me until I rebooted.

Plarpoon commented 8 months ago

Nope, also as said this persists across the past two versions of the program. I am winging it in this case but if I remember correctly it's something that is going on for approximately the whole past month, so I have rebooted many times since then.

AAGaming00 commented 8 months ago

Maybe try building from source and see if the electron upgrade fixed it

Plarpoon commented 8 months ago

Sure thing, will try during the whole of today to reproduce the bug on the source version, thanks for the idea so we can narrow further down the issue!

Plarpoon commented 8 months ago

Despite using nothing else but Vesktop source for the entire day, the problem persists. In fact, it has already occurred three times in just the past 15 minutes.

Interestingly, it seems to occur when I’ve been silent for a prolonged period and then suddenly start talking again. This pattern leads me to believe that the issue might be related to transitioning from a state of silence to sudden activity.

I’ve also checked the console log for any useful information, but it doesn’t seem to provide any relevant insights. Here is the link to the log for your reference.

If anyone wants me to do any specific test in real time I am up for it, even directly inside the Vencord Discord server (I am already there). Whatever can help you, I am seriously struggling to come with a reason on what this could be... Hopefully it's not another HW acceleration related bug because those are tough to resolve.

midblep commented 8 months ago

I've experienced the same issue. Alongside high pitched noises people have also told me they hear increasingly loud beeping or a lot of static noise. All of this goes away as soon as I use something like the official Discord web client.

Plarpoon commented 8 months ago

Lots of the beeping and noises for me it's not present (as long as KRISP is indeed enabled) but I do share the same experience as you

X1nto commented 8 months ago

Are you using venmic by any chance?

midblep commented 8 months ago

For me it's happening even with 0 plugins or themes. Clean install of Vesktop.

Curve commented 8 months ago

For me it's happening even with 0 plugins or themes. Clean install of Vesktop.

Venmic is not a plugin - It will be activated during screenshare with audio

Plarpoon commented 8 months ago

@X1nto Thank you for reminding me that I should have wrote down a list of active plugins, added it to the original post!

midblep commented 8 months ago

For me it's happening even with 0 plugins or themes. Clean install of Vesktop.

Venmic is not a plugin - It will be activated during screenshare with audio

Was not aware what it was. I am not screensharing or watching a screenshare when it happens. Just a normal one on one voice call.

Curve commented 8 months ago

For me it's happening even with 0 plugins or themes. Clean install of Vesktop.

Venmic is not a plugin - It will be activated during screenshare with audio

Was not aware what it was. I am not screensharing or watching a screenshare when it happens. Just a normal one on one voice call.

Thanks for confirming!

midblep commented 8 months ago

I tried this on Windows and Vesktop on Windows does not experience the same issue. I have only been getting it on Vesktop for Linux. (Ubuntu 23.10).

Curve commented 8 months ago

Please let me know if this also reproduces when never starting a Screen-Share

Plarpoon commented 8 months ago

It does reproduce consistently also while having a screenshare, but not necessarily at the precise moment you start it. This I know for a fact.

Curve commented 8 months ago

It does reproduce consistently also while having a screenshare, but not necessarily at the precise moment you start it. This I know for a fact.

This sadly doesn't really help, I'd have to know if it also reproduces when never starting a screen share in the first place

Plarpoon commented 8 months ago

Would you like to try in about 10 minutes on Vencord server?

midblep commented 8 months ago

Please let me know if this also reproduces when never starting a Screen-Share

Never as in, having never done it on that PC at all? Or having never started one in that call instance?

Curve commented 8 months ago

Please let me know if this also reproduces when never starting a Screen-Share

Never as in, having never done it on that PC at all? Or having never started one in that call instance?

Never as in never having started a screenshare in that vesktop instance

midblep commented 8 months ago

Please let me know if this also reproduces when never starting a Screen-Share

Never as in, having never done it on that PC at all? Or having never started one in that call instance?

Never as in never having started a screenshare in that vesktop instance

Yes, it happens then too. Yesterday I installed the flatpak to see if it happens there too. Clean install and I immediately go in a voice call to test, without cloud sync or settings on, and it immediately started doing weird noises.

Curve commented 8 months ago

Please let me know if this also reproduces when never starting a Screen-Share

Never as in, having never done it on that PC at all? Or having never started one in that call instance?

Never as in never having started a screenshare in that vesktop instance

Yes, it happens then too. Yesterday I installed the flatpak to see if it happens there too. Clean install and I immediately go in a voice call to test, without cloud sync or settings on, and it immediately started doing weird noises.

Alright thanks for confirming this - Should not be a venmic issue then ^^

Plarpoon commented 8 months ago

Confirming the same thing too then!

Also quick question, is everyone who is affected by this issue running on Ubuntu (or similar)? I have noticed @midblep saying he is running Ubuntu 23.10, I was running Kubuntu 23.10 until yesterday and now 24.04 (which is virtually identical).

If so we might finally have a clue on what it could be.

midblep commented 8 months ago

Confirming the same thing too then!

Also quick question, is everyone who is affected by this issue running on Ubuntu (or similar)? I have noticed @midblep saying he is running Ubuntu 23.10, I was running Kubuntu 23.10 until yesterday and now 24.04 (which is virtually identical).

If so we might finally have a clue on what it could be.

Actually, my bad, I am also running Kubuntu, not Ubuntu. 😅 Been meaning to upgrade to 24.04 soon as well, so I suppose we have rather identical systems.

Vendicated commented 8 months ago

i have this issue as well, but in my case it's just an issue with my microphone that also happens outside of vesktop. on windows it's fine. either because of driver differences or because krisp works better on windows

Plarpoon commented 8 months ago

As said I did notice this happens primarily when I am quiet for some time and then start talking, my guess is that it's not a KRISP issue but a gain issue.

Might be connected to an old bug I noticed, despite automatic gain control being disabled my microphone is still adjusted all the time up and down based on my level of voice, this bug is still happening to this day, could the two bugs be related? And yes, I can confirm the one adjusting the audio is Vesktop, no other application.

Issue #161

Vendicated commented 8 months ago

the automatic gain control toggle is not implemented in vesktop. automatic gain control is always on, see https://github.com/Vencord/Vesktop/issues/161

Plarpoon commented 8 months ago

Yes, that's my point, could it be a bug on the way that is implemented instead of being a KRISP issue?

RasmusRasmussen commented 8 months ago

Same issue in Pop!_os 22.04 Ubuntu based distro, I will try restart and not start a screenshare.

if my memory is correct is has been like this for almost two weeks

Plarpoon commented 8 months ago

As of now it looks like 3 out of 3 people experiencing this issue have an Ubuntu based distro then.

Please if anyone using something else can write a comment I would be very happy, at least we can finally say for certain the issue is there. Try to use Vesktop on Arch, Gentoo, Fedora or whatever peeps!

Jitzek commented 8 months ago

As of now it looks like 3 out of 3 people experiencing this issue have an Ubuntu based distro then.

Please if anyone using something else can write a comment I would be very happy, at least we can finally say for certain the issue is there. Try to use Vesktop on Arch, Gentoo, Fedora or whatever peeps!

I use Arch Linux x86_64 and unfortunately have the same problem:

I'll try out the AUR package instead of the Flatpak package to see if that makes any difference.

midblep commented 8 months ago

Does seem to be specific to Vesktop. Not getting the same problem in the official Discord app modded with Vencord, or other ones that have it as installation options like ArmCord.

Jitzek commented 8 months ago

As of now it looks like 3 out of 3 people experiencing this issue have an Ubuntu based distro then. Please if anyone using something else can write a comment I would be very happy, at least we can finally say for certain the issue is there. Try to use Vesktop on Arch, Gentoo, Fedora or whatever peeps!

I use Arch Linux x86_64 and unfortunately have the same problem:

* Stable 256231 (96a39c5)

* Vencord D73790e (Vesktop V0.4.4)

* Electron 27.1.2

* Chromium 118.0.5993.144

* Linux 64-Bit

I'll try out the AUR package instead of the Flatpak package to see if that makes any difference.

Tested it and the AUR package has the same issue.

Ysujy commented 8 months ago

Same issue on Arch with the vencord-desktop-git AUR package. Weirdly enough, only some participants notice the high-pitch sound.

vynwg commented 8 months ago

Same thing here. Sometimes only a single person hears the sound and the others don't. Automatic gain control is turned off, and I'm using KRISP noise suppression. Turning krisp off doesn't seem to change anything.

pipewire --version output:

Compiled with libpipewire 0.3.85
Linked with libpipewire 0.3.85

Vesktop info:

System info:

midblep commented 8 months ago

Just had my first occurrences of this exact thing happening inside Armcord with Vesktop.

Jokeronomy commented 8 months ago

This could have been introduced with an upgrade from the (old) vencord-desktop package, 0.4.4-3 -> 0.4.4-4 (Pacman package on Manjaro). That would seem to line up with when people in my VC's started to notice the sound (For me, I installed that on Jan 3rd, just about 3 weeks ago). I'm more than willing to do the legwork to manually figure out what commit may have introduced this bug, but I have no idea what commits were a part of that package - 0.4.4 is not even on the releases page. Given that it could realistically be a couple of hours (or more) to make the determination of it being broken or not, having that direction would really kinda be critical to determining the at-issue commit.

Can anyone point me in the right direction?

Curve commented 8 months ago

This could have been introduced with an upgrade from the (old) vencord-desktop package, 0.4.4-3 -> 0.4.4-4 (Pacman package on Manjaro). That would seem to line up with when people in my VC's started to notice the sound (For me, I installed that on Jan 3rd, just about 3 weeks ago). I'm more than willing to do the legwork to manually figure out what commit may have introduced this bug, but I have no idea what commits were a part of that package - 0.4.4 is not even on the releases page. Given that it could realistically be a couple of hours (or more) to make the determination of it being broken or not, having that direction would really kinda be critical to determining the at-issue commit.

Can anyone point me in the right direction?

You can see the history of the aur package here:

https://aur.archlinux.org/cgit/aur.git/?h=vencord-desktop

Specifically this commit updated it to 0.4.4-4: https://aur.archlinux.org/cgit/aur.git/commit/?h=vencord-desktop&id=72e35eab80216f86be91fe31dfd3ae520d7343c6

Jokeronomy commented 8 months ago

Thanks for that. After reviewing that commit to the AUR package, probably rather unlikely that it was that given the very minimal changes. I noticed that on my end, Electron25 was updated from 25.9.4 to 25.9.6 in the late December timeframe. It has since again updated to some 28 version due to the manjaro meta package updating. I've already downgraded the system package, is there a way to force vesktop to use a specific Electron version? I tried --electron-version=25.9.4, but that didn't do it.

D3SOX commented 8 months ago

is there a way to force vesktop to use a specific Electron version?

Just build it locally and replace it inside package.json.

Or with an approach like the vesktop-git AUR package uses the system electron: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=vesktop-git

AdivonSlav commented 8 months ago

Can confirm I also have this issue intermittently on Vekstop v1.5.0 Flatpak on Fedora 39

makidoll commented 7 months ago

I downgraded electron to 25.9.4 and that seems to have solved the issue. It might be on their side.

makidoll commented 7 months ago

I downgraded electron to 25.9.4 and that seems to have solved the issue. It might be on their side.

Seems like some people can still hear it but others don't. Hmm, I'm not sure what it is

Mixaz017 commented 7 months ago

Same issue on Arch Linux / KDE / PipeWire. Vesktop is installed using vencord-desktop-git AUR package and all installed packages are up to date. Tweaking voice related settings in Discord didn't help.

lewisakura commented 7 months ago

We are aware the issue exists and it happens on a wide variety of configurations. Unfortunately more comments aren't really helping and no more productive discussion is really occuring. Please continue technical discussions on our Discord server's development channel.

Locking.