Vencord / Vesktop

Vesktop is a custom Discord App aiming to give you better performance and improve linux support
GNU General Public License v3.0
4.12k stars 186 forks source link

screen share audio workaround not working after 'Change Windows' #555

Closed 888markus closed 4 months ago

888markus commented 6 months ago

Describe the bug

This bug is in version 1.5.2-alpha.1: When already having a stream (with mic workaround) and changing to another window, the workaround stops working (whether you have it on or not in the selection process of the new window). If you are ending the stream and starting a new one, the issue does not occur.

To Reproduce

Steps to reproduce the behavior:

  1. Hop on a call
  2. Choose to stream any window or screen
  3. Already have some audio playing in the background (i'm using Firefox)
  4. Select Firefox as audio source (with workaround on)
  5. Change the streaming window with 'Change Windows' button
  6. Select to stream any window or screen
  7. Select the same audio source as before (with workaround enabled)
  8. see error

Expected behavior

Firefox audio being streamed instead of my voice.

Screenshots Screenshot from 2024-05-01 14-52-56 After step 4, everything works fine Screenshot from 2024-05-01 14-53-42 But with the new window, the workaround doesn't work anymore.

Desktop (please complete the following information):

Command line output

[arRPC > ipc] listening at /run/user/1000/discord-ipc-0
[arRPC > websocket] listening on 6463
[arRPC > process] started
AppUpdater: Failed to check for updates
 Error: Incompatible version strings (old: 1.5.2-alpha.1, new: 1.5.1)
    at Tl (VCDMain:23:4006)
    at mo (VCDMain:23:4512)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[17656:0501/145210.056177:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
[17656:0501/145210.066095:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 2 times!
'loop->recurse > 0' failed at ../src/pipewire/thread-loop.c:426 pw_thread_loop_wait()
[2024-05-01 14:52:21.932] [venmic] [info] [patchbay] (get) running venmic 3.4.2
[2024-05-01 14:52:21.936] [venmic] [info] [patchbay] (handle) found default metadata: 36
[2024-05-01 14:52:21.936] [venmic] [info] [patchbay] (meta_update) speaker name: "alsa_output.pci-0000_2f_00.4.analog-stereo"
[2024-05-01 14:52:29.902] [venmic] [info] [patchbay] (create_mic) created: 85
'loop->recurse > 0' failed at ../src/pipewire/thread-loop.c:426 pw_thread_loop_wait()
[17656:0501/145250.351208:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 3 times!
'loop->recurse > 0' failed at ../src/pipewire/thread-loop.c:426 pw_thread_loop_wait()
[17620:0501/145321.100433:ERROR:egl_dmabuf.cc(608)] Failed to record frame: Error creating EGLImage - EGL_NOT_INITIALIZED
[17620:0501/145321.100457:ERROR:shared_screencast_stream.cc(940)] Dropping DMA-BUF modifier: 72057594037927935 and trying to renegotiate stream parameters
'loop->recurse > 0' failed at ../src/pipewire/thread-loop.c:426 pw_thread_loop_wait()
'loop->recurse > 0' failed at ../src/pipewire/thread-loop.c:426 pw_thread_loop_wait()
'loop->recurse > 0' failed at ../src/pipewire/thread-loop.c:426 pw_thread_loop_wait()
*** impl_ext_end_proxy called from wrong context, check thread and locking: Not in loop
*** impl_ext_end_proxy called from wrong context, check thread and locking: Not in loop
Vendicated commented 5 months ago

does this issue still persist on the latest version?

Vendicated commented 4 months ago

closing due to no response