Vencord / Vesktop

Vesktop is a custom Discord App aiming to give you better performance and improve linux support
GNU General Public License v3.0
2.37k stars 123 forks source link

New Update Broke GIFs and Video #562

Closed Godly-Avenger closed 1 month ago

Godly-Avenger commented 1 month ago

After updating to 1.5.2, I noticed that GIFs and videos load for a second and just shows white. The problem doesn't persist if hardware acceleration is turned off. Downgrading removes the issue.

Steps to reproduce the behavior:

  1. Make sure Hardware Acceleration is on.
  2. Open Vesktop
  3. Attempt to view a video or GIF.

Expected Behavior: I should be able to view videos and GIFs.

Screenshots

image

Desktop (please complete the following information):

Command line output

[arRPC > ipc] listening at /run/user/1000/discord-ipc-0
[arRPC > websocket] listening on 6463
[arRPC > process] started
[Vencord] Installed React Developer Tools
MESA-LOADER: failed to open nvidia: /usr/lib/gbm/nvidia_gbm.so: cannot open shared object file: No such file or directory (search paths /usr/lib/gbm, suffix _gbm)
(node:24805) ExtensionLoadWarning: Warnings loading extension at /home/godly_avenger/.config/vesktop/ExtensionCache/fmkadmapgofadopljbjfkapdkoienihi:
  Manifest version 2 is deprecated, and support will be removed in 2024. See https://developer.chrome.com/docs/extensions/develop/migrate/mv2-deprecation-timeline for details.

(Use `vesktop --trace-warnings ...` to show where the warning was created)
[24847:0501/152545.563976:ERROR:ozone_image_backing.cc(328)] OzoneImageBacking::ProduceSkiaGanesh failed to create GL representation
[24847:0501/152545.564159:ERROR:shared_image_manager.cc(228)] SharedImageManager::ProduceSkia: Trying to produce a Skia representation from an incompatible backing: OzoneImageBacking
[24847:0501/152545.569923:ERROR:ozone_image_backing.cc(328)] OzoneImageBacking::ProduceSkiaGanesh failed to create GL representation
[24847:0501/152545.570141:ERROR:shared_image_manager.cc(228)] SharedImageManager::ProduceSkia: Trying to produce a Skia representation from an incompatible backing: OzoneImageBacking
[24847:0501/152545.595013:ERROR:ozone_image_backing.cc(328)] OzoneImageBacking::ProduceSkiaGanesh failed to create GL representation
[24847:0501/152545.595308:ERROR:shared_image_manager.cc(228)] SharedImageManager::ProduceSkia: Trying to produce a Skia representation from an incompatible backing: OzoneImageBacking
[24847:0501/152545.613417:ERROR:ozone_image_backing.cc(328)] OzoneImageBacking::ProduceSkiaGanesh failed to create GL representation
[24847:0501/152545.613718:ERROR:shared_image_manager.cc(228)] SharedImageManager::ProduceSkia: Trying to produce a Skia representation from an incompatible backing: OzoneImageBacking
[24847:0501/152545.631811:ERROR:ozone_image_backing.cc(328)] OzoneImageBacking::ProduceSkiaGanesh failed to create GL representation
[24847:0501/152545.632250:ERROR:shared_image_manager.cc(228)] SharedImageManager::ProduceSkia: Trying to produce a Skia representation from an incompatible backing: OzoneImageBacking
[24847:0501/152545.647615:ERROR:ozone_image_backing.cc(328)] OzoneImageBacking::ProduceSkiaGanesh failed to create GL representation
[24847:0501/152545.647870:ERROR:shared_image_manager.cc(228)] SharedImageManager::ProduceSkia: Trying to produce a Skia representation from an incompatible backing: OzoneImageBacking
[24847:0501/152545.664126:ERROR:ozone_image_backing.cc(328)] OzoneImageBacking::ProduceSkiaGanesh failed to create GL representation
[24847:0501/152545.664585:ERROR:shared_image_manager.cc(228)] SharedImageManager::ProduceSkia: Trying to produce a Skia representation from an incompatible backing: OzoneImageBacking
[24847:0501/152545.668239:ERROR:ozone_image_backing.cc(328)] OzoneImageBacking::ProduceSkiaGanesh failed to create GL representation
[24847:0501/152545.668303:ERROR:shared_image_manager.cc(228)] SharedImageManager::ProduceSkia: Trying to produce a Skia representation from an incompatible backing: OzoneImageBacking
[24847:0501/152545.696563:ERROR:ozone_image_backing.cc(328)] OzoneImageBacking::ProduceSkiaGanesh failed to create GL representation
[24847:0501/152545.696812:ERROR:shared_image_manager.cc(228)] SharedImageManager::ProduceSkia: Trying to produce a Skia representation from an incompatible backing: OzoneImageBacking
[24847:0501/152545.715414:ERROR:ozone_image_backing.cc(328)] OzoneImageBacking::ProduceSkiaGanesh failed to create GL representation

Additional context

Covkie commented 1 month ago

Make sure youre running vesktop through X11 with electron29.

What are you system specs? Dual gpu?

Godly-Avenger commented 1 month ago

I haven't upgraded to electron 30 at all. My DE uses Wayland, but forcing X11 through --ozone-platform=x11 yields the same console error. My laptop does have two GPUs (integrated and a GTX 1650), but nvidia-smi shows that electron is using the dedicated.

Vendicated commented 1 month ago

gpu issue

Vendicated commented 1 month ago

actually it might be related to enabling the vaapi decoder. try running vesktop with --disable-features=VaapiVideoDecodeLinuxGL,VaapiVideoDecoder

if that doesnt work, try building from source while removing this line https://github.com/Vencord/Vesktop/blob/main/src/main/index.ts#L36

Godly-Avenger commented 1 month ago

That worked! Thank you!

Vendicated commented 1 month ago

hmmm... so we need to find an alternative solution to enabling vaapi, that sucks ☹️

AAGaming00 commented 1 month ago

no this is a setup issue, your gbm is broken

AAGaming00 commented 1 month ago

MESA-LOADER: failed to open nvidia: /usr/lib/gbm/nvidia_gbm.so: cannot open shared object file: No such file or directory (search paths /usr/lib/gbm, suffix _gbm) indicates a missing dependency for nvidia_gbm.so. ldd that library and find whats missing

Godly-Avenger commented 1 month ago

@AAGaming00 I can get rid of that message by using the GBM_BACKEND="nvidia-drm" environment flag, but the videos still don't load. Also that's a fairly common issue that doesn't affect much.

AAGaming00 commented 1 month ago

idk odd, works for me on non nvidia hyprland

AAGaming00 commented 1 month ago

@Godly-Avenger Does installing nvidia-vaapi-driver change anything?

Covkie commented 1 month ago

Odd that you're able to open vesktop at all under wayland on your setup: https://issues.chromium.org/issues/327780954. - actually maybe it opens because your drivers are failing something

Could you try using the closed source Nvidia drivers might be a mesa vaapi issue?

Godly-Avenger commented 4 weeks ago

I already have nvidia-vaapi-driver and the closed source drivers...