search

Vencord / Vesktop

Vesktop is a custom Discord App aiming to give you better performance and improve linux support
GNU General Public License v3.0
4.34k stars 195 forks source link

Screenshare broadcasts system-wide audio, not just that of the application. #569

Open bobismymom opened 6 months ago

bobismymom commented 6 months ago

Describe the bug

When streaming any application using Vesktop, audio from other applications is being picked up and broadcasted.

Expected behavior

Vesktop streaming only the audio of the application I selected to screenshare.

Desktop (please complete the following information):

Additional Context

I tried streaming VLC, Foobar2000, a variety of games and the issue persists.

Vendicated commented 6 months ago

yes this is intended

i don't think it's possible to stream just one window with electron api

PolisanTheEasyNick commented 6 months ago

Indeed, using electron API we can stream either all sound from Windows system or sound from one tab: image For now, we are setting audio parameter just to loopback: https://github.com/Vencord/Vesktop/blob/main/src/main/screenShare.ts#L80

Vendicated commented 6 months ago

that api has no option to choose a custom window. WebFrameMain refers to an electron frame, aka a frame of your own app. not other apps

PolisanTheEasyNick commented 6 months ago

that api has no option to choose a custom window. WebFrameMain refers to an electron frame, aka a frame of your own app. not other apps

Ohh, I see now. Anyway there's no way to choose another sound source :(

Tiagoquix commented 5 months ago

What does this issue mean for Linux? Does it render the "Audio source" selection somewhat useless?

Vendicated commented 5 months ago

this issue does not apply to Linux. only Windows

KIRUYXAN commented 3 weeks ago

That is, did I understand correctly that this cannot be fixed?