Vencord / Vesktop

Vesktop is a custom Discord App aiming to give you better performance and improve linux support
GNU General Public License v3.0
4.49k stars 198 forks source link

[Bug] Crash when attempting to screen share with pulseaudio #616

Closed gllxflr closed 6 months ago

gllxflr commented 6 months ago

Discord Account

rwrv

Operating System

Linux Mint 20.3 Cinnamon

Linux Only ~ Desktop Environment

Cinnamon

What happens when the bug or crash occurs?

Attempting to start a screenshare causes Vesktop to freeze when it tries to grab audio devices in the share menu.

What is the expected behaviour?

The audio device selector works, although without app-specific audio since pulse can't do that

How do you recreate this bug or crash?

Join a VC, click the button to start a screen share, choose an individual window, it should hang as soon as the next screen appears.

Debug Logs

Apologies, can't give these because I've just switched to Pipewire, which works.

Request Agreement

Curve commented 6 months ago

Please refer to https://github.com/Vencord/venmic/issues/20. I could not reproduce the issue on Mint Edge, as well as latest Mint.

Would appreciate more input if possible, including logs and so on (See the other issue for more information)

gllxflr commented 6 months ago

Cannot give logs, but can say the following

VictorMolokanov commented 6 months ago

same problem

Curve commented 6 months ago

Fixed in venmic v3.5.0

Curve commented 6 months ago

Cannot give logs, but can say the following

* Vesktop is the latest stable Flatpak version

* Mint was close to a fresh install

* Pipewire is already installed and running by default, same was the case with the Xfce install on my laptop. Unsure why, given no session manager is installed with it, could possibly be related to choosing additional codecs in Mint installer? Unsure, but could be a cause of the issue. This isn't my doing as I've observed this on totally fresh installs of Mint, both Cinnamon and Xfce. This is most likely the cause of the issue.

Fun fact: I could only reproduce this on a truly fresh install of Mint. As soon as I ran apt update & upgrade the problem went away ^^

Non the less, venmic v3.5.0 now has a one second timeout before it gives up and aborts the patchbay creation (and rohrkabel now has the proper facilities to enable this behavior)

gllxflr commented 6 months ago

Interesting, considering I was facing the crash after updates. Anyway, glad it's solved

VictorMolokanov commented 6 months ago

i maked update, and problem is still going. i'm on mint cinamon and after updating vesktop nothing changes.

Vendicated commented 6 months ago

vesktop hasnt updated with the patch yet. we will do so next update or you can build from source by following instructions in readme