Vencord / Vesktop

Vesktop is a custom Discord App aiming to give you better performance and improve linux support
GNU General Public License v3.0
3.84k stars 179 forks source link

[Bug] Process ID (PID) leaking memory in windows #624

Open LucHeart opened 4 months ago

LucHeart commented 4 months ago

Discord Account

lucheart

Operating System

Windows 11 / 10

Linux Only ~ Desktop Environment

No response

What happens when the bug or crash occurs?

During normal usage, or even only background usage of Vesktop, there is a few processes that are being created and die immediately after. This means PID's will rise to insanely high numbers and causes a memory leak in windows machines.

You can observe this behavior via Process Monitors Process Tree

See my screenshot. It shows the lifetime of the processes created and destroyed. This is the only program on my computer that does this.

image

What is the expected behaviour?

Not leaking PID's and Memory

How do you recreate this bug or crash?

Just have Vesktop open.. was able to observe this behaviour with different Machines on win 11 and 10, with different discord accounts.

Debug Logs

Dont think its relevant here, lmk if you need anything else tho

Request Agreement

Vendicated commented 4 months ago

that's arrpc, it's normal. can you explain in what way this supposedly causes memory leaks?

LucHeart commented 4 months ago

i specifically suspect WMIC to leak handles, only been having memory leaks with anything that touches it. What is it used for in vesktop anyways?

Vendicated commented 4 months ago

arrpc

LucHeart commented 4 months ago

i see, im gonna continue to observe vesktop for now i guess. but just sayin, polluting pid's is not a good practice in any way. am mostly interested in the memory leak am experiencing over a longer period atm

LucHeart commented 4 months ago

Very much the cause of my memory leak in my system. Havent used vesktop since, no PID spam, no memory leak

Vendicated commented 3 months ago

you can just disable Rich presence for the time being to stop this from happening. you will have to fully close & restart vesktop once to apply this setting

image

if you can confirm that this is indeed caused by RPC, you should report this upstream in the arRPC repo.