search

Vencord / Vesktop

Vesktop is a custom Discord App aiming to give you better performance and improve linux support
GNU General Public License v3.0
2.74k stars 138 forks source link

[Feature Request] Port vibrancy feature from vencord #651

Open Earthquake125 opened 3 weeks ago

Earthquake125 commented 3 weeks ago

Motivation

Transparency on Vesktop on macOS simply makes the window transparent.

image

Solution

Instead, I believe a Vibrancy/blur effect should be added, like Vencord on Discord:

image

Alternatives

N/A

Request Agreement

PolisanTheEasyNick commented 3 weeks ago

Looks like we can achieve it by setting vibrancy: "under-window" and visualEffectState: "followWindow" while creating window when transparency enabled in settings. src/main/mainWindow.ts:

        ...(transparent && {
            transparent: true,
-           backgroundColor: "#00000000"
+          backgroundColor: "#00000000",
+          vibrancy: "under-window",
+          visualEffectState: "followWindow"
        }),

Need further testing. I will get access to MacOS device tomorrow to try it and PR.

Vendicated commented 3 weeks ago

vencord already has vibrancy. it just needs to be ported

ryzendew commented 2 weeks ago

would be nice to do something like for kde as well

Vendicated commented 2 weeks ago

not really possible. this feature is powered by a macOS api that only exists there. you can combine the vesktop transparency feature with a compositor like picom to achieve something similar

Earthquake125 commented 2 days ago

Looks like we can achieve it by setting vibrancy: "under-window" and visualEffectState: "followWindow" while creating window when transparency enabled in settings. src/main/mainWindow.ts:

        ...(transparent && {
            transparent: true,
-           backgroundColor: "#00000000"
+          backgroundColor: "#00000000",
+          vibrancy: "under-window",
+          visualEffectState: "followWindow"
        }),

Need further testing. I will get access to MacOS device tomorrow to try it and PR.

Works perfectly except for window borders disappearing, but this could be an electron bug as it happens without Vibrancy as well as Vencord with it. a workaround is to fullscreen and un-fullscreen

image