Vencord / Vesktop

Vesktop is a custom Discord App aiming to give you better performance and improve linux support
GNU General Public License v3.0
3.51k stars 168 forks source link

[Bug] Share screen with audio causes loud audio spikes for streamer #772

Open different-name opened 1 month ago

different-name commented 1 month ago

Discord Account

different_name

Operating System

NixOS

Linux Only ~ Desktop Environment

Hyprland

Package Type

Flatpak & nixpkgs

What happens when the bug or crash occurs?

When sharing screen with audio, me - the person screen sharing, will occasionally experience a very loud spike in volume for a split second. This only occurs when streaming with audio I tried recording this through obs, but the audio spike does not occur in the recording

What is the expected behaviour?

Consistent system volume whilst streaming with audio

How do you recreate this bug or crash?

  1. Start a stream with audio (entire system or application, doesn't matter)
  2. Use computer normally, with sound playing

Debug Logs

Logs from starting vesktop to when the issue occured

$ flatpak run dev.vencord.Vesktop

Note that the directories 

'/var/lib/flatpak/exports/share'
'/home/different/.local/share/flatpak/exports/share'

are not in the search path set by the XDG_DATA_DIRS environment variable, so
applications installed by Flatpak may not appear on your desktop until the
session is restarted.

Using NVIDIA on Wayland, disabling gpu sandbox
Wayland socket is available, running natively on Wayland.
To disable, remove the --socket=wayland permission.
Passing the following arguments to Electron: --enable-speech-dispatcher --disable-gpu-sandbox --ozone-platform-hint=auto
[3:0720/210557.454761:ERROR:bus.cc(407)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
APPIMAGE env is not defined, current application is not an AppImage
checkForUpdatesAndNotify called, downloadPromise is null
[3:0720/210557.695957:ERROR:bus.cc(407)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
[3:0720/210557.696011:ERROR:bus.cc(407)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
(node:3) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '/home/different/.var/app/dev.vencord.Vesktop/config/vesktop/settings/quickCss.css'
    at async open (node:internal/fs/promises:636:25)
(Use `vesktop.bin --trace-warnings ...` to show where the warning was created)
(node:3) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
{ discordBranch: 'stable', minimizeToTray: 'on' }
[3:0720/210630.162870:ERROR:shared_x_display.cc(39)] Unable to open display
'loop->recurse > 0' failed at ../src/pipewire/thread-loop.c:426 pw_thread_loop_wait()
[2024-07-20 21:06:32.400] [venmic] [info] [patchbay] (handle) found default metadata: 41
[2024-07-20 21:06:32.401] [venmic] [info] [patchbay] (meta_update) speaker name: "alsa_output.usb-TC-Helicon_GoXLR-00.HiFi__Speaker__sink"
[2024-07-20 21:06:32.401] [venmic] [info] [patchbay] (get) running venmic 6.1.0
[2024-07-20 21:06:37.029] [venmic] [info] [patchbay] (create_mic) created: 152
[3:0720/210637.058050:ERROR:shared_x_display.cc(39)] Unable to open display
[3:0720/210637.102114:ERROR:shared_x_display.cc(39)] Unable to open display

Request Agreement

different-name commented 1 month ago

I use the nixpkgs day to day, did a fresh install of the flakpak today for this issue and same result. I did not import or configure any vesktop settings on the flatpak, I only signed in and started a stream. So I don't think this is configuration related

kotudemo commented 1 month ago

I have the same issue on Windows

kekkodance commented 1 month ago

same

dotaxis commented 1 month ago

I have been wondering for a long time what was causing these audio spikes and didn't realize it was only happening while I was streaming. I even bought a new DAC because I thought that was the culprit.

How bizarre.

Arch btw, using the vesktop-git AUR package.

dweee commented 1 month ago

Across Windows and NixOS too.

megumann commented 3 weeks ago

Across Windows and NixOS too.

I can confirm that this is occurring on Windows systems as well. Those who watch the stream report being able to hear audio system-wide instead of isolated to the application when streaming a specific window.

different-name commented 3 weeks ago

Tried this on Windows today, more like the audio stutters than the spikes I got on NixOS. Very different sound