[Bug] Noise suppression is enabled regardless of setting

Vencord / Vesktop

Vesktop is a custom Discord App aiming to give you better performance and improve linux support

GNU General Public License v3.0

4.5k stars 199 forks source link

[Bug] Noise suppression is enabled regardless of setting #795

Open kitrodian opened 4 months ago

kitrodian commented 4 months ago

Discord Account

kitrod

Operating System

Linux Mint 22 Cinnamon

Linux Only ~ Desktop Environment

Cinnamon Xorg

Package Type

Deb

What happens when the bug or crash occurs?

Regardless of the status of the noise suppression setting under Voice & Video, my microphone sounds like it is being noise suppressed incredibly hard when testing and to other users in a call. My microphone sounds perfectly fine and clear outside of Vesktop.

What is the expected behaviour?

Noise suppression should be disabled when it is set to None in Discord's settings.

How do you recreate this bug or crash?

Try disabling noise suppression
Run a mic test within Discord Example

Debug Logs

No errors in command line.

Request Agreement

[x] I have searched the existing issues and found no similar issue
[X] I am using the latest Vesktop and Vencord versions
[X] This issue occurs on an official release (not just the AUR or Nix packages)

Vendicated commented 4 months ago

likely related to https://github.com/Vencord/Vesktop/issues/161, try running the script someone posted in the replies and see if it fixes it

kitrodian commented 4 months ago

likely related to #161, try running the script someone posted in the replies and see if it fixes it

If you're talking about the launch option listed, I tried this and it made zero difference. Microphone quality is still really bad

Vendicated commented 4 months ago

https://github.com/Vencord/Vesktop/issues/161#issuecomment-1939532757

kitrodian commented 4 months ago

No difference.

kitrodian commented 4 months ago

After further investigation, this seems to be an issue with how programs that use Pulseaudio grab microphone input through pipewire-pulse. I have the same issue within Steam and Firefox.

Vendicated commented 4 months ago

if that's the case then it's an issue in chromium and not fixable from our side sadly

kitrodian commented 4 months ago

Did some more research, I was apparently completely incorrect. This is a problem with Vesktop (and other clients that wrap around the web version of Discord) that doesn't happen in the stock Discord app. There's something with the web version of Discord that Vesktop wraps around that causes this.

PolisanTheEasyNick commented 4 months ago

that doesn't happen in the stock Discord app

You mean discord web client or discord desktop client?

kitrodian commented 4 months ago

that doesn't happen in the stock Discord app

You mean discord web client or discord desktop client?

Desktop Discord client. This issue occurs in the web version of Discord but not in the official Desktop client.

TimkaSR1 commented 3 months ago

Having same issue on Windows

lewisdoesstuff commented 3 months ago

Can also replicate this, issue present on Vesktop and Discord web, but not the stock desktop client (AUR)

mintyZer0 commented 3 months ago

Has anyone found a workaround for this?

lewisdoesstuff commented 3 months ago

I've been using standard discord in the meantime.

I'd honestly be pretty fine with a toggle/plugin that strips/disables noise suppression entirely though

kerriganx commented 3 months ago

The issue persist only if you do "Mic test" in Discord settings. The actual microphone sounds normal to other users in a call. I did a quick test playing some music through my microphone and hear from second discord account. It looks like noise suppression is used only when I press "Let's Check" button

https://github.com/user-attachments/assets/d367dc7f-0834-4b42-8d5a-682daab67109

lewisdoesstuff commented 3 months ago

How strange, also seems to be the case here

TimkaSR1 commented 3 months ago

I've heard people say to me that my mic is cutting off when I'm talking so I don't think it's only the case for mic test

On Tue, Aug 27, 2024, 8:27 PM lew @.***> wrote:

How strange, also seems to be the case here

— Reply to this email directly, view it on GitHub https://github.com/Vencord/Vesktop/issues/795#issuecomment-2313135564, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCKKYJ3WA3RHW445D5CWM6LZTSZHHAVCNFSM6AAAAABL6IZZTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJTGEZTKNJWGQ . You are receiving this because you commented.Message ID: @.***>

DexlerXD commented 2 months ago

Also the case for me, but in addition to that my mic input is delayed for 1-2 seconds. This only happens in web discord cilent or vesktop, official flathub desktop discord client doesn't have that issue.
Really makes me still use the official client...

pallaswept commented 2 days ago

Also the case for me, but in addition to that my mic input is delayed for 1-2 seconds. This only happens in web discord cilent or vesktop, official flathub desktop discord client doesn't have that issue. Really makes me still use the official client...

Let's not hijack this issue for that one: https://github.com/Vencord/venmic/issues/35