search

Vencord / Vesktop

Vesktop is a custom Discord App aiming to give you better performance and improve linux support
GNU General Public License v3.0
4.29k stars 191 forks source link

[Bug] Journal flooded with error messages due to software video decode #852

Closed kode54 closed 2 months ago

kode54 commented 2 months ago

Discord Account

kode54

Operating System

Arch Linux

Linux Only ~ Desktop Environment

labwc

Package Type

Flatpak

What happens when the bug or crash occurs?

Video calls cause the journal to be flooded with messages:

[55:0912/211527.751544:ERROR:gbm_pixmap_wayland.cc(82)] Cannot create bo with format= YUV_420_BIPLANAR and usage=SCANOUT_CPU_READ_WRITE

Once per frame of video displayed.

What is the expected behaviour?

No error message flood.

How do you recreate this bug or crash?

  1. Start the app
  2. Log in
  3. Start a voice call
  4. Enable video

Debug Logs

There is no crash.

Request Agreement

kode54 commented 2 months ago

The issue can be fixed by disabling an Electron feature, like YouTube Music desktop app does:

https://github.com/th-ch/youtube-music/issues/2248

I have worked around the feature with the AUR vesktop-bin package by creating a ~/.config/vesktop/vesktop-flags.conf file containing at least:

--disable-features=UseMultiPlaneFormatForSoftwareVideo
Vendicated commented 2 months ago

i don't think disabling some feature just to prevent log spam is a good idea. it really doesn't matter, and disabling features might lead to negative side effects; chromium added it for a reason. people who want to observe the log and not have this noise can just filter it out using tools like grep or even pass the flag themselves

Vendicated commented 2 months ago

"UseMultiPlaneFormatForSoftwareVideo DISABLED on Chromium M120+ is causing pink H264 video tinting in WebRTC media streams for Windows devices with old GPUs" https://issues.chromium.org/issues/41485883

kode54 commented 1 month ago

The .desktop file has to be edited to control what messages are logged. My DE logs all stdout/stderr from every application to the systemd journal.

Also, I was not saying to disable it anywhere but Linux. I guess this is an Electron bug.

Or a Wayland bug:

https://www.reddit.com/r/Ubuntu/comments/1d4vxqd/errors_on_chrome_while_playing_videos_on_wayland/

Mikilio commented 1 month ago

While I can understand not wanting to disable a feature that seems to be on in electron by default. The issue you referenced seems to be fixed, so I don't see why that would realistically be an issue, though. If it is preferred to fix that issue upstream, the issue should at least be kept open because GitHub's default filters only show open issues.

The issue for this particular thing is already in Chromium under: https://issues.chromium.org/issues/331796411

Mikilio commented 1 month ago

It also seems like a fix has already been merged, so we just need to wait for upstream to update.